search

final-form / react-final-form

🏁 High performance subscription-based form state management for React
https://final-form.org/react
MIT License
7.39k stars 481 forks source link

onSubmit type signature - is callback really optional? #1003

Open sKopheK opened 2 years ago

sKopheK commented 2 years ago

Are you submitting a bug report or a feature request?

bug report

What is the current behavior?

https://final-form.org/docs/react-final-form/types/FormProps#onsubmit

callback?: (errors?: SubmissionErrors) => void,

What is the expected behavior?

callback: (errors?: SubmissionErrors) => void,

I believe callback parameter is passed everytime, it's just matter of function itself if it wants to use it.