final-form / react-final-form

🏁 High performance subscription-based form state management for React
https://final-form.org/react
MIT License
7.39k stars 482 forks source link

Fix departing rerender counters #1006

Open chervyakovru opened 2 years ago

chervyakovru commented 2 years ago

Right now forms RenderCounts move to top right corner of window. Added position: relative to form for catching counter in form

https://codesandbox.io/s/github/final-form/react-final-form/tree/master/examples/subscriptions

Now: image

Fixed: image

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0032ba97a13de8bc1c3ccafd8b9f66c97e0e575:

Sandbox Source
React Final Form - Simple Example Configuration
React Final Form - Synchronous Record Level Validation Configuration
React Final Form - Synchronous Field Level Validation Configuration
React Final Form - Submission Errors Configuration
React Final Form - Subscriptions Example Configuration
React Final Form - Subscriptions Example PR
chervyakovru commented 1 year ago

@erikras can you merge it, please? This simple update has already helped several of my friends