Rewrite To Typescript - Githubissues

final-form / react-final-form

🏁 High performance subscription-based form state management for React

https://final-form.org/react

MIT License

7.39k stars 482 forks source link

Rewrite To Typescript #1028

Closed dearlordylord closed 1 year ago

dearlordylord commented 1 year ago

(the title is an intended pun)

Thank you for a great library!

Looking for libraries and comparing them, I often look at Github's "languages" and I give less attention to libraries still written in JS.

I believe many people do the same but that could be a fallacy as well.

You use .js file extension for your Typescript code and Github wrongly picks it as JS.

I believe it would make a good service to your project "SEO" if you use .ts file extensions

BATCOH commented 1 year ago

Actually, the usage of the .js extension is reasonable - it's not typescript. AFAIK the library was written at a time when ts wasn't as popular as it is now. And it mainly uses flow for types.

There are many similarities between flow and typescript code, but they are different. And to switch to typescript you really need to rewrite the code, changing the extension will not be enough.

dearlordylord commented 1 year ago

Oh, my bad - thank you for this clarification! I failed to recognize Flow as haven't worked with it at all. I shall close this issue as it now could be considered a shitpost lol.