search

final-form / react-final-form

🏁 High performance subscription-based form state management for React
https://final-form.org/react
MIT License
7.39k stars 481 forks source link

The 3.0k bundle size claim is false #646

Open ghost opened 5 years ago

ghost commented 5 years ago

Are you submitting a bug report or a feature request?

I'm submitting a comment about the bundle size claim in your README.

What is the current behavior?

The README states that your bundle size is 3.0k gzipped. That is false because this library simply will not working without including final-form as well. Therefore, your bundle size is more like 8.1k gzipped at this time. See 1 and 2.

Not only that, to get all of the features of a well-known competitor that this is probably being compared to (Formik) you must include react-final-form-arrays 3 which adds another 1.3k for a total of 9.4k gzipped.

So, the claim of a 3.0k gzipped bundle size seems unfair to devs who are comparing these libraries.

What is the expected behavior?

That one can actually get all of the advertised functionality while only adding 3.0k to their gzipped bundle size. It's impossible.

Sandbox Link

None.

What's your environment?

Latest.

Other information

VincentCharpentier commented 5 years ago

I'd argue that final-form-arrays is not required, especially for common forms (login/register/account settings). This is precisely one of the goal of this library; Being modular. However I agree that a side note to indicate the weight of FF+RFF (8k) would be a useful information.