finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
908 stars 358 forks source link

top ranking stars intro background problem #1483

Closed kounabi22 closed 1 year ago

kounabi22 commented 1 year ago

At top ranking stars when the game start the intro is missing the background theme of fire,it apears only a black color, same goes at character selection screen. and in the game the backgrounds are all mix up.

y-ack commented 1 year ago

...shoot. this is a mame regression too. will look into. can you report on mametesters.org?

y-ack commented 1 year ago

fortunately the problem is simple but evidently i will need some time to test further regressions to make sure the fix is correct. thank you.

barbudreadmon commented 1 year ago

@y-ack btw, i don't know if you are interested but there was also that report about taito f3, i couldn't find anything about it at mametesters

dinkc64 commented 1 year ago

y-ack, hehe, I wasn't paying attention here, but I just came to the conclusion that the (y!=y_start) code caused it. oops :)

y-ack commented 1 year ago

yep -- we don't want to apply the scaling on the first line but we still need to read for latching purposes - trstar uniquely latches the first value in that section.

y-ack commented 1 year ago

try this: https://github.com/y-ack/mame/commit/974e26d197940c646ef0b7028a667ba323b78ade

revert the (y!=y_start) conditional wrapper from taitof3_video.cpp:1857~1885 and add @ 1939

        y +=y_inc;
    }
+   // ignore the first zoom value from ram and use the default
+   _y_zoom[y_start] = 0;
+   line_t->x_zoom[y_start] = 0x10000;

    UINT8 *pmap = bitmap_flags[which_map];
dinkc64 commented 1 year ago

@y-ack thank you! :)

barbudreadmon commented 3 months ago

note: Taito f3 video emulation was rewritten in MAME (thanks to @y-ack), and the following issues were fixed :

I'm pretty sure some of those bugs were reported here, but i couldn't find the original reports (it was probably from that guy who was constantly opening duplicates of the same bugs, i forgot the name, i think github deleted his account and all his messages at some point), so i'm posting this here instead.