finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
884 stars 356 forks source link

Graphics bug in Data East dec0 games on big-endian #1612

Closed vaguerant closed 7 months ago

vaguerant commented 7 months ago

Not able to test on PC at the moment so this is only confirmed on libretro Wii U currently. It's possible this is not endian-related, will test on PC as soon as I'm able to confirm.

Games tested

Description

Graphics entering about the middle 1/3 of the screen will vanish from view.

In this screenshot from the hbarrel attract sequence, the player character is walking on nothing because the ground underneath them has vanished: hbarrel-231209-025705

Similarly, this shot from the intro after starting a new game shows the plane partially disappearing as it crosses the middle: hbarrel-231209-030911

FBNeo version

libretro Wii U 523e3f8

dinkc64 commented 7 months ago

Hi vaguerant, The game works perfectly on pc w/fbneo, I'll take a look to see if I can find any endian-related things that could use adjusting.

@crystalct, hi, there, could you possibly test this on your PS3 and see if similar endian issues happen? (edit: please grab the new burn/drv/dataeast/d_dec0.cpp first)

best regards,

dinkc64 commented 7 months ago

vaguerant, some good news: I found a couple endian-bugs and fixed them - I'm confident that this will fix the problem, please give it a try when a new build is available :)

best regards,

vaguerant commented 7 months ago

Made a Wii U build locally which cherry-picked your fix, I can confirm it's completely fixed: hbarrel-231209-165917 hbarrel-231209-165931

Great stuff, many thanks!

dinkc64 commented 7 months ago

great! :)