search

finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
884 stars 356 forks source link

[Feature Request] Freeplay options available in libretro core #1614

Open rtomasa opened 7 months ago

rtomasa commented 7 months ago

As stated in the title, I saw that the standalone version of FBNeo provides a very nice feature for freeplay functionality, so -f enables native support (when available), and -F forces a Select/Coin button press when pressing Start. Would be possible to make these options available in the Libretro implementation? That would be really nice.

dinkc64 commented 7 months ago

Hi, I'm not aware of this feature, where exactly are you seeing it?

best regards,

rtomasa commented 7 months ago

It is here: https://github.com/finalburnneo/FBNeo/blob/master/README-PI.md down below in Command-line switches section. I think that a new Freeplay option with Disabled/Native(dipswitch)/Hack values should be OK to match these options

barbudreadmon commented 7 months ago

@dinkc64 It looks like someone wrote some code for this at https://github.com/finalburnneo/FBNeo/blob/master/src/burner/pi/main_pi.cpp#L51-L85. I can't imagine how it could work though considering it makes a case-sensitive search for "freeplay" or "free play", which are never seen in our codebase. It looks like that pi port is badly documented. Nvm, it's actually case-insensitive search.

@rtomasa I'm not that much interested in "bypass hacks" for dipswitches, in my experience sometimes they are not gonna be safe. I somehow tolerate the "Neo-Geo mode" core option (for "simplified" bios selection) in the libretro port, which is something similar, but if you ask me my opinion about it, it was a workaround when dipswitch support was missing in that port and it should have been removed when they became available. I'll only consider implementing this if it becomes something available in standalone (the real one on windows, what you linked is a half-finished unmaintained alternative port and should probably be refered as the "pi port").

rtomasa commented 7 months ago

It's fair to me. I did not check in the codebase, so I assumed that this feature was something already present in the mainline project and not an isolated hack for the Pi version. The -f solution sounds very tricky to me too. The -F has more sense since is just an extra button press that works well in most of the cases (I have this already mimicked using Retroarch mappings). In any case thanks for looking into this and provide these details.