search

finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
918 stars 361 forks source link

(libretro) Dip switches bios (fronted menu problem) #1632

Closed hatetepe closed 8 months ago

hatetepe commented 8 months ago

The fbneo libretro version has a small but annoying bug. Changing the BIOS in dip switches (no matter which one) does not return to the BIOS options, but goes down to the memory card. This happens every time I start the game and try to change the bios. Strangely enough, if I try to change the bios a second time (without turning off and restarting the game), everything is fine. It's a bit bothersome because I'm creating my game list using Fb Neo and I often change the bios.

barbudreadmon commented 8 months ago

Changing the BIOS in dip switches (no matter which one) does not return to the BIOS options, but goes down to the memory card.

Sorry but i have absolutely no idea what you mean. I think you'll need to provide a video or something.

hatetepe commented 8 months ago

Sorry, I'll try to be more specific:

When I change the bios for the rom here: Zrzut ekranu 2024-01-08 215912

Fronted index no return to bios but automatically jumps down to memory card. Zrzut ekranu 2024-01-08 220330

I noticed one more thing. This only happens once, as I have already mentioned, and when there is no previously changed and saved BIOS configuration for a given game.

I use the xmb menu and windows.

barbudreadmon commented 8 months ago

Ok, well, strictly speaking, this is frontend behavior, the core doesn't choose which core option is selected in the frontend.

However it is probably originating from the "coin chutes" dipswitches, and i think their dynamic visibility (many core options are dynamically visible) is behaving wrongly, so i'll take a look soon.

barbudreadmon commented 8 months ago

So yeah, i was right, there was a bug about the 2 "coin chutes" dips being visible at boot. It is fixed with https://github.com/libretro/FBNeo/commit/4138e7d4f949780f4176f6c174177eb3b6cc2789.

It should prevent retroarch from moving the core option cursor since now the list of core options doesn't shrink anymore after changing bios. Please note that there might be other cases where a growing/shrinking list can't be avoided, in which case retroarch will still have that behavior and there won't be anything possible to avoid it on core's side.

hatetepe commented 8 months ago

Thank you for solving the problem.