search

finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
917 stars 362 forks source link

SFZ3Mix, Samples in Netplay #1688

Closed sfz3mix closed 7 months ago

sfz3mix commented 7 months ago

In Retroarch, if you use Samples, Netplay doesn't work. It probably has something to do with the savestate

ghost commented 7 months ago

does it work with regular FBNeo ? win32/win64

dinkc64 commented 7 months ago

its probably an issue of one side using samples and other side not using samples, and when retroblarch syncs the states they don't match size-wise, will look into a possible solution soon.

sfz3mix commented 7 months ago

Yes, that's probably dinkc64. Thanks for your support.

barbudreadmon commented 7 months ago

@dinkc64 maybe the following would do the trick

        if (Cps2Turbo && ~nAction & ACB_NET_OPT) {
            BurnSampleScan(nAction, pnMin);
        }

?

It should fix the size issue, however i'm not entirely sure if playback will work properly for the player with samples.

I can think of either that or initing "mute" samples when the real ones are missing.

sfz3mix commented 7 months ago

I've solved some problems this way by also playing empty.wav (mute sound) when there's no sound with the correct id. Remember that in this case there will be nothing for those who don't use the samples folder.

dinkc64 commented 7 months ago

Added a potential fix for this, please give it a try: https://github.com/finalburnneo/FBNeo/commit/66b3d4e3fd0cec3c89824f420eb6147b6d2c71e3

best regards,

sfz3mix commented 7 months ago

Hello, FBNeo team, I opened a room on Retroarch and I couldn't connect when one person was using samples and the other was not. The message appears (Disconnected from NetPlay). It only worked when both were using samples or not. It would be good if it worked with or without samples for both parties.

barbudreadmon commented 7 months ago

The libretro fork isn't synced after every single commit, and i haven't synced this particular commit yet (i'll do that asap). Even after syncing, the new version won't be instantly available, downloaded and installed by everyone. It's not rare to see people using versions that are several months old, if not worse.

I suggest making tests locally if you can, or to wait a few days/weeks.

sfz3mix commented 7 months ago

My test used the latest build from this site on the sides https://buildbot.libretro.com/nightly/windows/x86_64/latest/ But thanks for the tip, I'll do more tests over time. :+1:

dinkc64 commented 7 months ago

Can you try again after core update? I saved a state with sample use, then removed samples, reloaded and load state works - this wouldn't have worked before the fix, so, I think it should be OK now.

best regards,

sfz3mix commented 7 months ago

I updated and tested it again and it worked. Thanks again to the entire FBNeo support team. 👍