search

finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
881 stars 355 forks source link

add hack hsf2jpp/hsf2app #1734

Closed alhumbra closed 3 months ago

alhumbra commented 3 months ago

Although a US version of hsf2pp already exists Japanese (hsf2jpp) and Asian (hsf2app) versions have been added.

The hacker's name, Yumeji, and the date have been added to the ROM information A script that can generate Roms in HTML can be downloaded from (Japanese website) https://ux.getuploader.com/yumeji/download/21

screen shot hsf2jpp

taoenwen commented 3 months ago

https://github.com/finalburnneo/FBNeo/issues/1726

@alhumbra Is it necessary to add hacks that are only regionally different?

alhumbra commented 3 months ago

Of course. English is not the only language.

taoenwen commented 3 months ago

Of course. English is not the only language.

FBNeo offers a variety of possibilities, such as:

barbudreadmon commented 3 months ago

Adding 3 times the same hack because of language, for a game where the texts don't matter at all, feels a bit excessive.

dinkc64 commented 3 months ago

I think its ok, well, the only concern I have - why is the picture on the left side black? Was the patching successful?

alhumbra commented 3 months ago

@dinkc64 Thank you for allowing the merge.

The patch matches the author's CRC, so it is probably not a problem.

Those captured from FBNeo were normal. hsf2jpp-03-24-230315

Even the non-hacked version has black lines on both sides. test000

I think it's the environment, GPU or blitter some other issue.