finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
879 stars 354 forks source link

need opinion about dinotpic #1821

Closed barbudreadmon closed 23 hours ago

barbudreadmon commented 3 days ago

So there was a discussion about c&d chinese bootlegs at https://forums.libretro.com/t/cadillacs-and-dinossaurs-bootleg-the-bgm-sound-loop-version/45289

It seems there was a bootleg with dinotpic gameplay (picking up gold dust bag gets you 15 sec invincible time, 3 bomb per life, button ‘c’ to active drop bomb, chance to get umlimited ammo when you pick guns) but dinohunt music (music loop on boss).

Considering dinotpic's music roms don't seem to belong to the real dinotpic pcb anyway (we are softpatching the program file so that it can run the qsound roms from the parent romset ? while the original program is expecting oki6295 samples ?), should we consider replacing this romset's music by dinohunt's ?

taoenwen commented 3 days ago

Currently dinotpic is already using QSound via hack, it's on by default, except for P3, P1 & P2 have Fire 3, but it's not possible to confirm the existence of P3's Fire 3 on the real PCB, due to the fact that in the early days in China, a lot of gaming consoles didn't have a full set of buttons, e.g., SF2, which had only 3 fists.

barbudreadmon commented 3 days ago

Currently dinotpic is already using QSound via hack

Sorry if i wasn't clear, my proposition was to remove that hack and use the oki6295 samples from dinohunt instead.

taoenwen commented 3 days ago

Currently dinotpic is already using QSound via hack

Sorry if i wasn't clear, my proposition was to remove that hack and use the oki6295 samples from dinohunt instead.

OK

taoenwen commented 3 days ago

remove that hack and use the oki6295 samples from dinohunt instead.

Unfortunately, by removing the hack and using dinohunt's oki samples, the dinotpic sound didn't work properly.

barbudreadmon commented 3 days ago

Too bad :/

barbudreadmon commented 23 hours ago

I couldn't get it to work either. Closing !