search

finalburnneo / FBNeo

FinalBurn Neo - We are Team FBNeo.
http://neo-source.com
Other
909 stars 359 forks source link

sfiii3u Graphics Misalignment [Regression] #278

Closed Awakened0 closed 4 years ago

Awakened0 commented 4 years ago

There's a strange alignment problem I found that's best shown with a comparison: http://www.framecompare.com/image-compare/screenshotcomparison/J2ME1NNU

You can also see a slight difference in colors compared to MAME. I've only tested the libretro core; not sure if these are there in stand alone.

Awakened0 commented 4 years ago

Ahh, it's aligned properly in a build from Jan 31st, so it must be something with the recent CPS3 changes.

dinkc64 commented 4 years ago

@barbudreadmon maybe its something to do with that offset we were talking about the other night?

barbudreadmon commented 4 years ago

I'll be away this week-end, i'll try to see what's wrong next week. Leaving in a few minutes, 1 wild guess would be https://github.com/finalburnneo/FBNeo/commit/900ce38004857e091ae74204234c6e717fb591f8#diff-d51bfb6a692321f4224209e955b76d48R1829 and next line I did the "+1" change to follow current mame code but this change wasn't part of the commit i backported

dinkc64 commented 4 years ago

barbudreadmon, that was it :) I committed the change

Awakened0 commented 4 years ago

Built the libretro core with that change and it looks good. Thanks!

barbudreadmon commented 4 years ago

cool :)