search

finale-lua / lua-scripts

A central repository for all Lua scripts for Finale.
https://finalelua.com
Creative Commons Zero v1.0 Universal
15 stars 14 forks source link

[BUG] RTFNotes eats AdditionalMenuOptions et al #686

Closed rpatters1 closed 7 months ago

rpatters1 commented 7 months ago

Describe the bug When the bundler builds the RTFNotes from Notes it erroneously eats the AdditionalMenuOptions, AdditionalUndoText, and AdditionalDescriptions if they follow Notes, which they often do.

To Reproduce Examine any dist version of a script with AdditionalMenuOptions. beam_selected_region.lua is an example.

@asherber

asherber commented 7 months ago

Hmm, that didn't come up in my testing, but I'll look into it today.

rpatters1 commented 7 months ago

Actually, it looks like it may be eating everything to the end of (the 'src' version of) plugindef (from Notes).

asherber commented 7 months ago

Can't think of why but thanks for the info.

asherber commented 7 months ago

Just to confirm: When you say "eats", you mean that the items which appear after Notes are getting presented in the RTF -- but they're also still present in plugindef(), right? That's what it looks like to me, just want to make sure you're not seeing something else.

rpatters1 commented 7 months ago

That's right, and the double [[]] in the subsequent fields also messes up the "stringness" of RTFNotes.

asherber commented 7 months ago

Yup, I see it, fixing it now.

asherber commented 7 months ago

Hmm, the PR didn't kick off a deployment. I need to grab some lunch, will investigate in a bit.

asherber commented 7 months ago

Oh, it did, I was reading Vercel wrong. Everything look okay to you?

Edit: I guess no deploy was actually needed, since there are no changes to the site itself. It's just the dist files, which the website grabs from GH.

rpatters1 commented 7 months ago

Looks good to to me.