finalfusion / finalfusion-tensorflow-ops

Tensorflow Op for finalfusion embeddings
https://finalfusion.github.io/
Other
2 stars 0 forks source link

Restrict compiler version to first two digits in all cases. #19

Closed sebpuetz closed 5 years ago

sebpuetz commented 5 years ago

Previously, the version was only restricted if len == 3. g++ sometimes returns version strings including a date, thus not triggering the statement.

@twuebi ran into this issue in a docker container where the compiler version returned by tf was 5.4.0 followed by some date while the available compiler was also 5.4.0, which should've been valid. The compiler was rejected because 5.4.0 followed by a year is interpreted as a higher version than a simple 5.4.0.