search

finallion / Artificial_Foliage-FABRIC-

This minecraft mod allows you to build and terraform anywhere with the grass and foliage color you like independent from the actual biome
Creative Commons Zero v1.0 Universal
2 stars 3 forks source link

Fixed breakage of vanilla mechanics and block dupe exploit #15

Closed Friskygote closed 3 years ago

Friskygote commented 3 years ago

Hello! Sorry for double PR. It will be more granular if I do them separately I though I suppose. This PR addresses the issue where vanilla mechanics of Nylum spread would stop working since the mod would effectively replace the final block with whatever is at the end of block searching iterator (which can be any block, creating an exploit which could allow players to clone blocks). This removes the final else clause (which shouldn't be triggered by exiting break above anyways because we are looking for 4 specific blocks in the iterator). The final result of this PR is that if we don't find four specific blocks from AfRo we just pass the handling of function back to Minecraft instead of overwriting the block with one specific block at the end of block iterator.

Hope I were clear enough. If this implementation is not good enough, again, I don't mind closed PR, you can just treat it as a bug report then. :) Hope you have a nice day.

Friskygote commented 3 years ago

Uh, sec, I just need to remove one line which I don't know why is still there EDIT: ok fixed, sorry for that, I'm not sure why it didn't sync up completely with my local Git repo.

finallion commented 3 years ago

Thats great, thanks - this would have been pretty annoying figuring out!

Friskygote commented 3 years ago

No problem, I'm glad to help out, that's the least I can do for modding community for years of great amounts of fun I had with mods. Thank you for your contribution to this community, really appreciate it.