search

finani / ICM42688

Arduino library for communicating with the InvenSense ICM42688 nine-axis IMUs.
MIT License
47 stars 21 forks source link

implement software SPI (not tested), custom TwoWire instance (tested) #19

Open wb1016 opened 1 month ago

wb1016 commented 1 month ago

by using Adafruit's LSM6DS and BusIO library as reference, i have implemented software SPI and ability to accept custom TwoWire instance. this is quite necessary for various ESP32 boards since they dont use predefined pins for communication. this is my first cpp work. code review is welcomed.

finani commented 1 month ago

Thank you for your contribution!

The default target board is Arduino, so please add comments like this.

I checked a few points do not follow formats such as whitespace in the parenthesis, but don't mind about formats. I will update the format file and apply it all.

Everything else looks great!

One thing I worried about is I have no test device now. Could you test your code with SPI?

wb1016 commented 1 month ago

i only have my test device in I2C interface. i'll ask someone to test my code instead.

finani commented 1 month ago

Awesome! Thank you!