Closed mtsokol closed 1 month ago
check-finch
now. I'll add tests at check-finch
at some point. If you are annoyed by all the error messages, you can just build Finch-mlir
with cmake --build .
without testing.Thank you for explanation!
- I'm currently only playing with main cpp implementation and haven't checked the python part yet. What is the file and command that I can reproduce it?
In the repo there's test/python/smoketest.py
file. I added from mlir_finch import execution_engine
to the imports section to reproduce it:
from mlir_finch.ir import *
from mlir_finch.dialects import builtin as builtin_d, finch as finch_d
from mlir_finch import execution_engine
Having built llvm-project
and Finch-mlir
as component build (as described in README.md
) I export PYTHONPATH
:
export PYTHONPATH=/home/mtsokol/Finch-mlir/build/python_packages/finch
and then run:
python test/python/smoketest.py
@nullplay I've got one more question. We started to work on user-facing Python bindings layer (the API that the user will have access to for creating tensors etc.).
Let's agree on a specific LLVM version (or git hash) that our code and Finch-mlir
repo is going use, so once we plug the new dialect it goes smoothly. For example latest stable LLVM release 18.1.8
and latest main
branch has some API differences in Python Bindings.
Latest pre-release is 19.1.0-rc2
(https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0-rc2). Maybe we can agree on using 19.x
branch? and 19.1.0
once is released? Or 18.1.8
tag?
Maybe we can agree on using 19.x branch? and 19.1.0 once is released? Or 18.1.8 tag?
@nullplay In the meeting we agreed that 19.1.x version should be targeted for our development. It will be released in two weeks: https://discourse.llvm.org/t/llvm-19-1-0-rc3-released. Right now RC3 is available.
I added appropriate cmake extension for execution_engine
in python/CMakeLists.txt
at latest push. I can now run from mlir_finch import execution_engine
without an error. Could you check if it works?
Now it all works - thank you!
Hi @nullplay,
I rebuild
Finch-mlir
locally with the latest version ofmain
branch inllvm-project
. I've got two questions:README.md
instructions and incmake --build . --target check-finch
four tests are failing (logs in details), is it expected to happen?Finch-mlir
, and I noticed that importingexecution_engine
fails. I didn't spend much time on this but I think there might be a missing dependency inDEPENDS
orLINK_LIBS
in one of theCMakeLists.txt
files: