Avoid adding deps every setup

finch-tensor / finch-tensor-python

Sparse and Structured Tensor Programming in Python

MIT License

8 stars 3 forks source link

Closed mtsokol closed 6 months ago

mtsokol commented 6 months ago

This PR makes sure that Finch dependency is added only once. This should improve startup time (both locally and in benchmarks).

willow-ahrens commented 6 months ago

Lgtm! Did this end up improving the runtime? The pkg add should already be caching what it can, so I'm curious if this is noticeably faster.

mtsokol commented 6 months ago

The startup is faster for sure - import finch does run faster if it has already been imported with a given version.

willow-ahrens commented 6 months ago

awesome!