Closed mtsokol closed 6 months ago
Declare it first with tns .= 0
Do you think we should just add speye and spdiags to finch? I'll work on that this evening.
eye
is pretty simple to implement in finch-tensor
, but sure - Finch functions that follow:
finch-tensor
. We could have format=...
argument there? Or always return coo
I just realized that speye and spdiags are classic matlab functions, so we should probably also do it in Finch.jl
Declare it first with
tns .= 0
It helped - thank you! For now we have format=...
keyword argument that supports dense
and coo
by building an expression that is evaluated.
Sure! Maybe we should merge this and create an issue in the Finch repo for spdiags and speye
Sure!
I created an issue. The PR is ready I think.
Hi @willow-ahrens @hameerabbasi,
This PR adds
eye
Array API function.@willow-ahrens I think that as a follow-up I could add
format
argument but, for COO:it fails with: