search

finch-tensor / finch-tensor-python

Sparse and Structured Tensor Programming in Python
MIT License
8 stars 3 forks source link

API: More elemwise and reduction functions #35

Closed mtsokol closed 5 months ago

mtsokol commented 5 months ago

Hi @hameerabbasi,

This PR adds another batch of elemwise and reduction functions.

mtsokol commented 5 months ago

I'd also add checks for dtype and shape. Otherwise LGTM.

Done! I added checks for these Tensor's attributes.

willow-ahrens commented 5 months ago

It occurs to me that perhaps the list of exported names in the module would be a good place to start counting supported functions, is that right?

mtsokol commented 5 months ago

We merged array-api-tests CI job in sparse (https://github.com/pydata/sparse/pull/668) that shows how many functions are already implemented (~46 right now).