API: Add verbose mode and lazy indexing

finch-tensor / finch-tensor-python

Sparse and Structured Tensor Programming in Python

MIT License

8 stars 3 forks source link

Closed mtsokol closed 5 months ago

mtsokol commented 5 months ago

Hi @hameerabbasi,

This PR:

bumps Finch version to the latest release
adds support for the debug/verbose compute mode
adds support for lazy indexing, e.g. tns[:, None, :], that adds a new singleton dimension at that position. There's an issue with the rightmost None indexing (https://github.com/willow-ahrens/Finch.jl/issues/528) but I think we can merge it here and I will update tests once it's solved in Finch.jl.

mtsokol commented 5 months ago

@hameerabbasi FYI there's one regression that causes one test failure: https://github.com/willow-ahrens/Finch.jl/issues/524

hameerabbasi commented 5 months ago

@hameerabbasi FYI there's one regression that causes one test failure: willow-ahrens/Finch.jl#524

Let's also add it to xfail for now.

hameerabbasi commented 5 months ago

Thanks for getting to this so quick, @mtsokol! In it goes.