Closed mtsokol closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
main@0c3a202
). Click here to learn what that means.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think we should fix that ambiguity error too though. I'll add the issue to finch.jl
Sure! For now it's a small fix here in finch-tensor
.
Can we add a regression test? Something which ensures
permute_dims
will always compile?
Sure! Done! I extended test_permute_dims
so it also runs lazy mode (it passes here and fails in a main branch).
Thanks for the diagnosis and the work put towards fixing this, @mtsokol!
Hi @hameerabbasi @willow-ahrens,
This small fix makes
permute_dims
usejl.permutedims
instead ofjl.swizzle
.It's needed to make transpositions work in the lazy mode, because for
swizzle(lazy(tensor), ...)
we get:and
permutedims
doesn't raise it.