finch-tensor / finch-tensor-python

Sparse and Structured Tensor Programming in Python
MIT License
8 stars 3 forks source link

`__mod__` can return incorrect results #53

Closed hameerabbasi closed 5 months ago

hameerabbasi commented 5 months ago
          Ouch -- `__abs__` was a mistake, imho. We should add the divisor instead if the result is negative.

Originally posted by @hameerabbasi in https://github.com/willow-ahrens/finch-tensor/issues/51#issuecomment-2116987378