This PR refines order support, by allowing finch.asarray(any_input, format=any_format) regardless of any_input order.
Right now it's accomplished by calling copyto! and then dropfills which I think performs copy twice. Could it be achieved with a one function call? (or performing one copy)
copyto! for dense source and sparse (e.g. csr) destination copies all elements including fill values as non-fill ones (therefore it requires dropfills)
Hi @willow-ahrens @hameerabbasi,
This PR refines order support, by allowing
finch.asarray(any_input, format=any_format)
regardless ofany_input
order.Right now it's accomplished by calling
copyto!
and thendropfills
which I think performs copy twice. Could it be achieved with a one function call? (or performing one copy)copyto!
for dense source and sparse (e.g.csr
) destination copies all elements including fill values as non-fill ones (therefore it requiresdropfills
)dropfills!
fails forcsr
format as shown here https://github.com/willow-ahrens/Finch.jl/issues/609#issuecomment-2186636101