search

finddx / FINDCov19Tracker

https://dsbbfinddx.github.io/FINDCov19Tracker/
Other
0 stars 1 forks source link

remove git_mod #12

Closed findanna closed 3 years ago

findanna commented 3 years ago

When negative values are found in the file that Imane uploads, the porcessed/coronavirus_tests.csv is not updated and this is a clear indication that we should correct the uploaded file (alson in the log of the action run).

The git_mod does not allow us to update the processed/data_all.csv file even after we upload a corrected file, since the file with the negative values is recently modified.

findanna commented 3 years ago

AFAIR this change was desired from you back then to prevent the processing of files that include negative tests.

I am not fully following the reasoning here but if that helps and does not introduce negative test data as a consequence, feel free to merge.

You can adapt anytime again 👍

Indeed! When we see the error, we correct the file and upload it straight away. Since there are no negatives anymore both coronovirus_tests.cvs and data_all.csv should now get updated. However, data_all.csv does not get updated, because here you check if there are any modifications on the issues folder, correct? Is there a way to circumvent this?

pat-s commented 3 years ago

I don't have it in mind right now and would need to take a closer look (if neded). Is there a need?

Otherwise feel free to merge this one if that helps in the short run now.