search

findhy / mp4parser

Automatically exported from code.google.com/p/mp4parser
0 stars 0 forks source link

Wrong SPS values shown in avcC Box (PPS values also) #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open any MP4 file with valid H.264 bitstream
2. Open avcC Box and find SPS[1] values parsed incorrectly
3. At the same time fields "avcLevelIndication" and "avcProfileIndication" have 
correctly parsed values.

What is the expected output? What do you see instead?
I.e. High Profile @ Level 4.0 is shown with: profile_idc=103 (impossible value) 
and constraint_set(x)_flag booleans also wrong

What version of the product are you using? On what operating system?
2.0 RC16 on win7

Please provide any additional information below.
I could at least make profile_idc and constraint_set_x_flag fields show correct 
values. PPS still has issues as well.
"dirty hack" patch file attached

Original issue reported on code.google.com by christia...@castlabs.com on 28 Nov 2012 at 5:18

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed in trunk. Flag 4 & 5 is correct. It has been added in a later version of 
the spec. Skipping the byte at the beginning is not ok to do in SPS itself. 
It's the NAL header, it must be skipped before passing the data to the SPS 
parser (same for PPS). Has been fixed in trunk. I'll release a new build this 
year.

Original comment by Sebastian.Annies on 26 Dec 2012 at 11:11