findify / s3mock

Embedded S3 server for easy mocking
MIT License
387 stars 107 forks source link

Follow symlinks in FileProvider #131

Closed ukeller closed 4 years ago

ukeller commented 6 years ago

This allows for a prepolated s3 bucket without copying potentially large files.

er1c commented 5 years ago

The default should already be to follow symlinks: https://github.com/pathikrit/better-files/blob/00be8b37f7a8f73364708300ee96bb07908d285a/core/src/main/scala/better/files/File.scala#L1486

I don't know if this is needed, or if that was a change in the better files API that is simply fixed by updating to a newer library version. (the git blame for that line hasn't been changed in over a year)