search

findify / s3mock

Embedded S3 server for easy mocking
MIT License
387 stars 107 forks source link

Make it work with JDK10 #140

Closed automatictester closed 4 years ago

automatictester commented 5 years ago

I was running into issues JAXB-related NoClassDefFound on JDK10 when using s3mock as a test dependency in my Java project. Everything worked fine on JDK8. This appears to fix the problem. I believe this is related to #89.

er1c commented 5 years ago

I believe this should work by simply upgrading the alpakka version: https://github.com/akka/alpakka/issues?utf8=%E2%9C%93&q=is%3Aclosed+milestone%3A0.20+sort%3Aupdated-desc++label%3Ap%3Aaws-s3 - it added this in 0.20

er1c commented 5 years ago

For reference: https://github.com/findify/s3mock/pull/143 - compiles on java11 fine for me.

shuttie commented 4 years ago

merged (as the fork is private and there were conflicts, I had to apply it manually)