search

findify / s3mock

Embedded S3 server for easy mocking
MIT License
386 stars 107 forks source link

implement ListParts endpoint #174

Open as3richa opened 3 years ago

as3richa commented 3 years ago

@shuttie

this endpoint is used by the TransferManager for multipart uploads and copies

as3richa commented 3 years ago

ref. https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListParts.html.

for uploads and copies sufficiently large to require a multipart transfer, the TransferManager emits a ListParts requests immediately after the CreateMultipartUpload. prior to this patch a ListParts request would have routed to GetObject, causing the upload to fail

mickjermsurawong-stripe commented 3 years ago

hi @shuttie! Would you be able to take a look at this please?

We use TransferManager api extensively, which relies on part listing on large file. Currently, we have internal fork of s3mock and use the patch @as3richa created. It would be great if this patch can be pulled in and we can use the oos version instead.

mickjermsurawong-stripe commented 3 years ago

cc @romangrebennikov

mickjermsurawong-stripe commented 3 years ago

Hi there! Just would like to follow-up on this please. Would really appreciate if you could consider this patch. I believe it would also be valuable to others.