search

findingmarbles / Retromat

Retromat: Plans for (agile) retrospectives - Create, tweak, print, share
46 stars 25 forks source link

Last review of French translation. #55

Closed Zenigata closed 6 years ago

Zenigata commented 7 years ago

Why do I have the end of print retromat season commits appear here?

fiddike commented 7 years ago

Hi @Zenigata , good question. I just pulled all branches into my local repo and looked at them using SourceTree. These commits actually appear twice, with different commit hashes. Maybe somebody rebased. Hmm. However, a diff from current master to your latest commit on this PR works just fine and only shows your changes. => I guess this will be a very simple merge.

Looking forward merging this as soon as one of the french translators, e.g. @Artusamak indicates it's O.K.

Artusamak commented 7 years ago

Review done, @Zenigata thanks for the fixes, good catches. If you open more french PR, feel free to mention me, i'll be highlighted to review the changes faster. :)

Zenigata commented 7 years ago

I think I'm done with the French reviewing. Frow now on, I will add new translations when I have some free time. Sorry for this merge, the rebase is probably from me. If you can cherrypick my two commits, maybe it will be easier. Thx!

Zenigata commented 6 years ago

Hi @fiddike , do you want me to create another merge request? What do we do with this one? Thanks for your time :)

fiddike commented 6 years ago

Hi @Zenigata, thank you for the reminder. After attending the World Scrum Gathering I was busy catching up with work and family obligations 8-) Just merged your PR, thank you for the fixes!