search

findmate / cordova-plugin-jitsi-meet

Cordova plugin for jitsi meet react native sdk
17 stars 21 forks source link

Is there a way to include user info in loadURL call #5

Open cdecaux opened 4 years ago

cdecaux commented 4 years ago

Hi there,

Thanks for your work. Plugin works great on both iOS and Android !

I have a suggestion though. (I don't know anything about building plugins, so pardon me if this is completely out of bounds)

I looked at the react-native-jitsi-meet project which I understand is the base of this plugin. And it seems that there is way to include some user info as mentioned in the Readme:

const userInfo = { displayName: 'User', email: 'user@example.com', avatar: 'https:/gravatar.com/avatar/abc123' }; JitsiMeet.call(url, userInfo);

How difficult is it to add a extra variable to the jitsiplugin.loadURL function call such as: jitsiplugin.loadURL(url, key, isInvisible, userInfo, ...)

Thanks for your help

Christophe

slothentic commented 4 years ago

Hi there, in this case I would suggest you to fork the plugin if you need to add some custom functionality.

As of now, I don't have any plans to add such functionality. If you were open to developing it, I would be happy to merge in any changes that allowed passing custom data, as that sounds like others could benefit from it as well.

theavijitsarkar commented 4 years ago

Yes this is a really useful feature