findmypast-oss / mssql_ecto

Ecto adapter for Mssqlex
Apache License 2.0
49 stars 20 forks source link

Allow custom ports for connections to SQL server DBs #1

Closed shdblowers closed 7 years ago

shdblowers commented 7 years ago

Expected Behavior

That I can set any port for the connection in my config, like so:

config :my_app, MyApp.Repo,
  adapter: MssqlEcto,
  hostname: "localhost"
  port: "9494"

Current Behavior

Port config is ignored.

Possible Solution

Implement code change to allow it to happen, most likely will need changes to Mssqlex as well.

Context

Trying to use custom ports.

Your Environment

jbachhardie commented 7 years ago

You can still do ports right now by specifying hostname: "localhost,4000" for example, although I'm all for a PR that makes that more elegant.

shdblowers commented 7 years ago

Fixed by #17