Add type 'datetimeoffset' to type mappings in the README.md.

findmypast-oss / mssql_ecto

Ecto adapter for Mssqlex

Apache License 2.0

49 stars 20 forks source link

Add type 'datetimeoffset' to type mappings in the README.md. #11

Closed fpauser closed 7 years ago

fpauser commented 7 years ago

Description

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

shdblowers commented 7 years ago

Hello, @fpauser! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

coveralls commented 7 years ago

Coverage remained the same at 88.316% when pulling 5e02320481fe0a2c271910b1f3d5ec79417606be on fpauser:document_datetimeoffset_support into 8f777e17116cddcfa1c1c2a39e2c6c728b0357b5 on findmypast-oss:master.

shdblowers commented 7 years ago

Hi @fpauser I could not find this Ecto type in the official documentation, do you have a link?

fpauser commented 7 years ago

Hi @shdblowers, you are right. As it looks support for datetimeoffset must be added to mssqlex.

shdblowers commented 7 years ago

I meant that I could not find it in the Ecto documentation.