findmypast-oss / mssql_ecto

Ecto adapter for Mssqlex
Apache License 2.0
49 stars 20 forks source link

upping mssqlex version, allowing support for custom ports #17

Closed shdblowers closed 7 years ago

shdblowers commented 7 years ago

Description

Following on from the change in mssqlex here: https://github.com/findmypast-oss/mssqlex/commit/81f0bbabe4a5fc6281d76234650c1e15bbcefaaf

Upping version of mssqlex to 0.7 will allow custom ports to be used.

Motivation and Context

This solves issue #1

How Has This Been Tested?

I cannot figure out a way to properly test this. The Microsoft SQL Server docker image does not allow you to set custom ports.

Types of changes

Checklist:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 88.316% when pulling f0c7c0125dc25d09a48e8ebe81e07e56ea7e18b1 on custom_ports into 444d2b13905fd5f6e9222a1c2d32831661d8ffa7 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 88.316% when pulling 6bf2629331c112311eea3a95b027b1cd0de23650 on custom_ports into 444d2b13905fd5f6e9222a1c2d32831661d8ffa7 on master.