findmypast-oss / mssql_ecto

Ecto adapter for Mssqlex
Apache License 2.0
49 stars 20 forks source link

Bumping Readme version to 0.3.1 from 0.3.0 #29

Closed cdesch closed 6 years ago

cdesch commented 6 years ago

Related to #28

Description

Bumping Readme version to 0.3.1 from 0.3.0

Motivation and Context

Copy and paste from readme cost me an hour of debugging. I bumped it 0.3.1 and it was resolved.

Fixes #28

shdblowers commented 6 years ago

Hello, @cdesch! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 88.276% when pulling 5e411a565eec1f6c02b2f23bce47e31e156ff013 on kickinespresso:master into ae2d5671e84787e3be8a9248f5c83211d819c0cc on findmypast-oss:master.

shdblowers commented 6 years ago

Thanks for spotting this @cdesch, how did this fix #28 ?

cdesch commented 6 years ago

I must have been hitting a bug in 0.3.0 that was fixed in 0.3.1. Not sure entirely.