Install correct MS ODBC package

pasibonfire commented 6 years ago

Description

Install msodbcsql17 for Debian 9

Motivation and Context

Running the tests failed, ODBC 17 was not found.

If you installed the v17 msodbcsql package that was briefly available, you should remove it before installing the msodbcsql17 package. This will avoid conflicts. The msodbcsql17 package can be installed side by side with the msodbcsql v13 package.

How Has This Been Tested?

Built a new image, ran docker-compose run mssql_ecto mix test

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

shdblowers commented 6 years ago

Hello, @pasibonfire! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

coveralls commented 6 years ago

Coverage remained the same at 86.174% when pulling f400721fc001d6898e280adb05687e48ade47b36 on pasibonfire:fix_dockerfile_odbc into 55366231fc52e4faeb914bb3207822b025b88cb7 on findmypast-oss:master.

shdblowers commented 6 years ago

@pasibonfire I think this is fixed now.

findmypast-oss / mssql_ecto