Adding clarity to readme on how to use non-ODBC drivers.

findmypast-oss / mssql_ecto

Ecto adapter for Mssqlex

Apache License 2.0

49 stars 20 forks source link

Adding clarity to readme on how to use non-ODBC drivers. #7

Closed shdblowers closed 7 years ago

shdblowers commented 7 years ago

Adding clarity to readme on how to use non-ODBC drivers.

Relates to #6

shdblowers commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

10 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/findmypast-oss/mssql_ecto/pulls/7.

coveralls commented 7 years ago

Coverage remained the same at 87.329% when pulling f4f1a9d347d46f10018b04b349686db73e2b9f16 on shdblowers-patch-1 into d8e6c27d76e660a5f44980e9f40c8b2b1ef4a728 on master.

jbachhardie commented 7 years ago

We should make clear what the defaults are for all these parameters and explain a bit about what they do. Currently it's just an example without much information.

shdblowers commented 7 years ago

Yeah, I put it as a PR as I wasn't sure how much this would help, or if it would even confuse people.

Something more informative should be put in the readme.