Make storage logic work

jbachhardie commented 7 years ago

The storage methods (storage_up, storage_down, structure_dump, structure_load) were erroneously implemented in MssqlEcto.Connection rather than MssqlEcto, causing them to not work with existing tooling.

Motivation and Context

Closes https://github.com/findmypast-oss/mssql_ecto/issues/8

How Has This Been Tested?

All tests passing. Tested by calling ecto.create on an existing project

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

shdblowers commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

10 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/findmypast-oss/mssql_ecto/pulls/9.

coveralls commented 7 years ago

Coverage increased (+1.0%) to 88.316% when pulling 602b89a0e2fa1d3bb51d5b930b2822c7b909200c on storage_bugfix into d8e6c27d76e660a5f44980e9f40c8b2b1ef4a728 on master.

findmypast-oss / mssql_ecto