search

findmypast-oss / mssqlex

Microsoft SQL Server Adapter for Elixir
Apache License 2.0
42 stars 22 forks source link

Fixing allowing Named Instances, adding it as an option #13

Closed shdblowers closed 7 years ago

shdblowers commented 7 years ago

Fixes the re-opening of https://github.com/findmypast-oss/mssql_ecto/issues/6 once it is pulled into mssql_ecto.

Adds :instance_name as an option to be given when connecting to a database.

This is tested with Travis by using a named instance, the default named instance MSSQLSERVER.

This PR also allows all options to be set through environment variables.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 83.721% when pulling 5183ee6bdd2d61238f6826c59590cf3a6067dd59 on custom_port_test into 5b8c88bbf07d6cc4105de804a632905d507a8776 on master.