update default version of the ODBC Driver to 17.

shdblowers commented 6 years ago

Description

Changing the default version that mssqlex expects the ODBC Driver to be. This is to reflect what version is installed when running apt-get install msodbcsql on Debian Jessie.

Motivation and Context

How Has This Been Tested?

Docker tests

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

shdblowers commented 6 years ago

This will cause breaking changes for users that rely on the default to be version 13.

shdblowers commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/findmypast-oss/mssqlex/pulls/17.

coveralls commented 6 years ago

Coverage remained the same at 86.822% when pulling bcfdd333a70709b6f070fd527eb2917a8b9412f9 on new-odbc-version into 3227e32b8493989db813c3644fefd76265df73b2 on master.

findmypast-oss / mssqlex