Allow configuring the encryption parameters

findmypast-oss / mssqlex

Microsoft SQL Server Adapter for Elixir

Apache License 2.0

42 stars 22 forks source link

Allow configuring the encryption parameters #18

Closed rzane closed 6 years ago

rzane commented 6 years ago

This allows configuring the connection's encryption.

Description

This just adds two extra flags to the connection string.

Motivation and Context

Some people like encryption.

How Has This Been Tested?

I ran the tests. I also wrote a new test that checks that the current connection has encryption.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

shdblowers commented 6 years ago

Hello, @rzane! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

coveralls commented 6 years ago

Coverage increased (+0.2%) to 87.023% when pulling 012e298f7538955f0ac1981f28dccb5d02e189ea on rzane:encryption into c3a415a61b2d3b6a42a902c3d51ea27001b69c1a on findmypast-oss:master.

rzane commented 6 years ago

hey @shdblowers, I'm pretty sure the CI failure isn't because if this PR.

shdblowers commented 6 years ago

Hi, thanks for the PR. Not quite sure what the problem is here, we were having some issues with our CI previously due to Microsoft keep swapping between versions 13 and 17 of the driver, but it is installing the expected version. Just seems to be installing in an unexpected location

shdblowers commented 6 years ago

@rzane rebasing/merge master on this branch should make it pass now :smile:

rzane commented 6 years ago

Okay, I just rebased. Would you be able to cut a release after this gets merged? It would really help me out.

shdblowers commented 6 years ago

Sure

shdblowers commented 6 years ago

1.1.0 is 🚀

rzane commented 6 years ago

👏