search

findmypast / vaultex

HashiCorp Vault client for Elixir.
106 stars 38 forks source link

Read configuration dynamically #31

Open thdxr opened 5 years ago

thdxr commented 5 years ago

Instead of reading the application configuration once and caching it in a GenServer, it should be read on demand when a request is made. This fits normal Elixir convention and doesn't depend on configuration being set in an explicit order.

More information on this concept here: https://michal.muskala.eu/2017/07/30/configuring-elixir-libraries.html

thdxr commented 5 years ago

Following up on this, is a GenServer even necessary?

olivierbuffon commented 4 years ago

I would also be interested by that change. We use Confex in our project and unfortunately because of the current implementation it won't work.

jvantuyl commented 3 years ago

I have a use-case that involves hitting two vault servers. Could really use this. Would a PR be accepted?

AtebMT commented 3 years ago

Absolutely. Most of the recent changes have come from PRs.