Closed TheKeymaster closed 5 years ago
Merging #13 into master will increase coverage by
0.22%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 99.77% 100% +0.22%
+ Complexity 190 182 -8
==========================================
Files 23 26 +3
Lines 442 501 +59
==========================================
+ Hits 441 501 +60
+ Misses 1 0 -1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/FINDOLOGIC/Definitions/OrderType.php | 100% <ø> (ø) |
1 <0> (ø) |
:arrow_down: |
src/FINDOLOGIC/Objects/XmlResponseObjects/Item.php | 100% <100%> (ø) |
12 <3> (ø) |
:arrow_down: |
src/FINDOLOGIC/Objects/JsonResponse.php | 100% <100%> (ø) |
4 <1> (+1) |
:arrow_up: |
...DOLOGIC/Objects/JsonResponseObjects/Suggestion.php | 100% <100%> (ø) |
12 <1> (+2) |
:arrow_up: |
src/FINDOLOGIC/Definitions/RequestType.php | 100% <100%> (ø) |
1 <1> (ø) |
:arrow_down: |
src/FINDOLOGIC/Validators/ConfigValidator.php | 100% <100%> (ø) |
4 <4> (?) |
|
src/FINDOLOGIC/Validators/ParameterValidator.php | 100% <100%> (ø) |
9 <9> (?) |
|
src/FINDOLOGIC/FindologicApi.php | 100% <100%> (ø) |
23 <3> (-12) |
:arrow_down: |
src/FINDOLOGIC/Helpers/ParameterBuilder.php | 100% <100%> (ø) |
42 <3> (-12) |
:arrow_down: |
src/FINDOLOGIC/Definitions/BlockType.php | 100% <100%> (ø) |
1 <1> (?) |
|
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f60de0c...21e8ab2. Read the comment docs.
@georgms most issues are fixed now. Please take a look at the open comments.
@georgms if you have nothing more to add I will merge this to the master
, since this PR is open for such a long time now :).
@georgms I will merge it today and create a release. Please add a comment here if you have anything to add.
@TheKeymaster Great work!