findologic / findologic-api

Library for sending requests to the Findologic API
MIT License
1 stars 3 forks source link

Request time should be attached to the response objects #14

Closed TheKeymaster closed 5 years ago

TheKeymaster commented 5 years ago

The timing related fields are instance variables of FindologicApi while an instance of FindologicApi can fire multiple requests. This is a mismatch, since the timing is related to the requests, not the FindologicApi instance, which is basically a factory for requests.

This is probably fine for now. In the future FindologicApi could be refactored to actually be a request factory, and then the timing info would be attached to the request class instances.