Using an object as URL may cause an error at valitron - Githubissues

findologic / findologic-api

Library for sending requests to the Findologic API

MIT License

1 stars 3 forks source link

Using an object as URL may cause an error at valitron #24

Closed TheKeymaster closed 4 years ago

TheKeymaster commented 5 years ago

We're using the validation library Valitron for validating submitted input by users of the library. This includes
- Adding parameters such as ->setUrl().
- Validating the submitted Findologic config. This affects the service URL.
There is a bug at the moment that prevents us from validating URLs, because the Validation can not handle objects as URLs and may throw an exception.

Add URL handling for those who need it if the bug is fixed at our validation library.

Please note: This issue does not have a high priority since this bug only occurs when using the library in a bad way.

TheKeymaster commented 4 years ago

Closing this issue as it is not library related - means we can not fix it here, so this is not the right place.