Closed TobiasGraml11 closed 5 years ago
@TobiasGraml11 I have found a critical bug that may be solved in this story. The bug causes the XML_2.1 not to work at all. When \FINDOLOGIC\Api\Responses\Response::checkResponseIsValid
is called, we get the body of the response with $response->getBody()->getContents()
and it seems like that when calling this method, Guzzle removes the local saved file and saves it into memory. This causes the Response to no longer get the contents in further code.
As for now let's just skip the check we introduced (lines 136-146). Please also adapt the tests accordingly.
Codecov Report
100% <100%> (ø)
4 <4> (?)
100% <100%> (ø)
8 <8> (?)
100% <100%> (ø)
14 <14> (?)
100% <100%> (ø)
15 <15> (?)
100% <100%> (ø)
3 <3> (?)
100% <100%> (ø)
7 <7> (?)
100% <100%> (ø)
16 <2> (-2)
100% <100%> (ø)
3 <3> (?)
100% <100%> (ø)
3 <3> (?)
100% <100%> (ø)
21 <7> (+9)
Continue to review full report at Codecov.