search

findologic / findologic-api

Library for sending requests to the Findologic API
MIT License
1 stars 3 forks source link

FINDO-8351 Add Filter and SDYM support for XML21 #43

Closed TobiasGraml11 closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #43 into add_support_for_xml21 will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             add_support_for_xml21    #43    +/-   ##
=======================================================
  Coverage                      100%   100%            
- Complexity                     257    321    +64     
=======================================================
  Files                           39     47     +8     
  Lines                          698    846   +148     
=======================================================
+ Hits                           698    846   +148
Impacted Files Coverage Δ Complexity Δ
...C/Api/Responses/Xml21/Properties/OriginalQuery.php 100% <100%> (ø) 4 <4> (?)
...INDOLOGIC/Api/Responses/Xml21/Properties/Query.php 100% <100%> (ø) 8 <8> (?)
...FINDOLOGIC/Api/Responses/Xml21/Properties/Item.php 100% <100%> (ø) 14 <14> (?)
...NDOLOGIC/Api/Responses/Xml21/Properties/Filter.php 100% <100%> (ø) 15 <15> (?)
...GIC/Api/Responses/Xml21/Properties/QueryString.php 100% <100%> (ø) 3 <3> (?)
...OGIC/Api/Responses/Xml21/Properties/Attributes.php 100% <100%> (ø) 7 <7> (?)
src/FINDOLOGIC/Api/Responses/Response.php 100% <100%> (ø) 16 <2> (-2) :arrow_down:
...INDOLOGIC/Api/Responses/Xml21/Properties/Limit.php 100% <100%> (ø) 3 <3> (?)
...INDOLOGIC/Api/Responses/Xml21/Properties/Range.php 100% <100%> (ø) 3 <3> (?)
...c/FINDOLOGIC/Api/Responses/Xml21/Xml21Response.php 100% <100%> (ø) 21 <7> (+9) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 802dddf...f531832. Read the comment docs.

TheKeymaster commented 5 years ago

@TobiasGraml11 I have found a critical bug that may be solved in this story. The bug causes the XML_2.1 not to work at all. When \FINDOLOGIC\Api\Responses\Response::checkResponseIsValid is called, we get the body of the response with $response->getBody()->getContents() and it seems like that when calling this method, Guzzle removes the local saved file and saves it into memory. This causes the Response to no longer get the contents in further code. As for now let's just skip the check we introduced (lines 136-146). Please also adapt the tests accordingly.