Closed zaifastafa closed 4 years ago
@TheKeymaster I had refactored these properties in their own classes, but it did not work. I will re-visit and see what can be done.
EDIT: For e.g this error comes up if I declare them in their own sub-classes:
Call to undefined method FINDOLOGIC\Api\Responses\Xml21\Properties\Filter\Item\DefaultItem::getColor()
@zaifastafa please check where this method is called. I am pretty sure it's in the tests, because they'd need to be changed in a way, so they understand which properties, which filter/item has. Updating the tests accordingly will probably fix this issue.
@TheKeymaster on a related issue, will the ColorFilter
also have an ImageItem
? Or that is an error in the test as well? because the demo XML is having an image as well in the color.
@zaifastafa that's for what tests are. Now it comes to my mind... Color filters can have image as well, please add the property for color filters as well :).
Codecov Report
100% <100%> (ø)
5 <5> (?)
100% <100%> (ø)
3 <3> (?)
100% <100%> (ø)
2 <2> (?)
100% <100%> (ø)
3 <3> (?)
100% <100%> (ø)
13 <13> (?)
100% <100%> (ø)
26 <14> (+3)
Continue to review full report at Codecov.