Closed TheKeymaster closed 5 years ago
@howard can be reviewed when you have time.
Merging #104 into develop will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## develop #104 +/- ##
========================================
Coverage 100% 100%
Complexity 261 261
========================================
Files 49 49
Lines 685 686 +1
========================================
+ Hits 685 686 +1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/FINDOLOGIC/Export/Data/DateAdded.php | 100% <100%> (ø) |
5 <1> (ø) |
:arrow_down: |
src/FINDOLOGIC/Export/Data/Item.php | 100% <100%> (ø) |
53 <1> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 902d1e6...aadc839. Read the comment docs.
@howard can be reviewed again.
@DomBra Thanks for the contribution! Merged the changes - they will be part of the next release. If you have any immediate use for it, please let me know so I can expedite it.
Purpose
If you have a custom
DateTime
object which extends from\DateTimeInterface
you can not set a date value, as would result in a type error.Approach
Instead of requiring an instance of
\DateTime
for\FINDOLOGIC\Export\Data\DateAdded::setDateValue
, just require an instance of\DateTimeInterface
.Open Questions and Pre-Merge TODOs
composer lint
andcomposer fix
was executed.