findologic / libflexport

FINDOLOGIC export toolkit for XML and CSV data export

MIT License

4 stars 5 forks source link

Add PHP 7.4 (snapshot) to build matrix #105

Closed howard closed 5 years ago

howard commented 5 years ago

Purpose

PHP 7.4 will arrive soon. Getting ready for it as soon as we can seems like a good idea.

Approach

Extend the build matrix to run with PHP 7.4 and see what happens.

Open Questions and Pre-Merge TODOs

[ ] ~~composer lint and composer fix was executed.~~ No code changes, only build config was updated.
[ ] ~~Tests were written and pass with 100% coverage.~~ Build config "tested" as part of build process.
[ ] ~~A issue with a detailed explanation of the problem/enhancement was created and linked.~~ Needless overhead for a simple change like this.

codecov-io commented 5 years ago

Codecov Report

Merging #105 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##             develop   #105   +/-   ##
========================================
  Coverage        100%   100%           
  Complexity       261    261           
========================================
  Files             49     49           
  Lines            686    686           
========================================
  Hits             686    686

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2029544...314c777. Read the comment docs.

howard commented 5 years ago

Waiting for a new release of squizlabs/php_codesniffer to get rid of deprecation messages in the build log for PHP 7.4.

howard commented 5 years ago

Those messages can't be reproduced locally, so I suspect it's something about Travis' environment, which we don't have influence over, so I'm going ahead to merge this.