findologic / libflexport

FINDOLOGIC export toolkit for XML and CSV data export
MIT License
4 stars 5 forks source link

Split up methods and update code parts #115

Closed mmachatschek closed 4 years ago

mmachatschek commented 4 years ago

Purpose

Updated some code parts.

Approach

Added one test for missing code unit.

Open Questions and Pre-Merge TODOs

mmachatschek commented 4 years ago

@howard what do you think about the changes?

codecov-io commented 4 years ago

Codecov Report

Merging #115 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             develop   #115   +/-   ##
========================================
  Coverage        100%   100%           
- Complexity       267    269    +2     
========================================
  Files             49     49           
  Lines            701    701           
========================================
  Hits             701    701
Impacted Files Coverage Δ Complexity Δ
src/FINDOLOGIC/Export/Data/Property.php 100% <ø> (ø) 11 <0> (ø) :arrow_down:
...OLOGIC/Export/Helpers/UsergroupAwareMultiValue.php 100% <ø> (ø) 10 <0> (ø) :arrow_down:
src/FINDOLOGIC/Export/Data/AllKeywords.php 100% <100%> (ø) 4 <0> (ø) :arrow_down:
src/FINDOLOGIC/Export/XML/XMLItem.php 100% <100%> (ø) 26 <0> (-1) :arrow_down:
src/FINDOLOGIC/Export/Data/Item.php 100% <100%> (ø) 59 <0> (ø) :arrow_down:
src/FINDOLOGIC/Export/Helpers/DataHelper.php 100% <100%> (ø) 17 <4> (+1) :arrow_up:
src/FINDOLOGIC/Export/CSV/CSVExporter.php 100% <100%> (ø) 9 <3> (+2) :arrow_up:
src/FINDOLOGIC/Export/CSV/CSVItem.php 100% <100%> (ø) 12 <0> (ø) :arrow_down:
src/FINDOLOGIC/Export/Exporter.php 100% <100%> (ø) 5 <1> (ø) :arrow_down:
src/FINDOLOGIC/Export/Data/AllOrdernumbers.php 100% <100%> (ø) 4 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56d23a3...75f6bf3. Read the comment docs.